Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with different queue sizes #13

Closed
j-hui opened this issue Jun 12, 2021 · 5 comments
Closed

Test with different queue sizes #13

j-hui opened this issue Jun 12, 2021 · 5 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@j-hui
Copy link
Collaborator

j-hui commented Jun 12, 2021

Having a size of 8192 means that we necessarily have at least 8192 repeated entries in the log before we encountere a contqueue full error. Can we consider dropping the queue size down to 128 or something so that the event trace is somewhat more easily auditable?

@Rewbert
Copy link
Collaborator

Rewbert commented Jun 13, 2021

We can, I increased it to be able to run some specific tests quite a while back. I don't know what the optimal size is though, if there is any.

@j-hui
Copy link
Collaborator Author

j-hui commented Jun 13, 2021

If there are reasons for setting the size larger, it sounds like this is something that we might even want to vary for the purposes of testing.

This was referenced Jun 13, 2021
@j-hui j-hui added the good first issue Good for newcomers label Jun 17, 2021
@j-hui j-hui changed the title Drop queue sizes for testing purposes Test with different queue sizes Jul 2, 2021
@j-hui
Copy link
Collaborator Author

j-hui commented Jul 2, 2021

A nice-to-have feature that should be fairly straightforward to support is to run each test multiple times, with different queue sizes.

@Rewbert
Copy link
Collaborator

Rewbert commented Jul 4, 2021

Modified the interpreter on branch #interpretable to be parameterised over the queue sizes. Should solve half of that feature ;-)

@j-hui j-hui mentioned this issue Jul 9, 2021
@j-hui
Copy link
Collaborator Author

j-hui commented Jul 9, 2021

Closed by #42

@j-hui j-hui closed this as completed Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants