Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Titles with dots or apostrophes not showing up #22

Open
AlyafeiAli opened this issue May 11, 2022 · 5 comments
Open

Titles with dots or apostrophes not showing up #22

AlyafeiAli opened this issue May 11, 2022 · 5 comments

Comments

@AlyafeiAli
Copy link

Long time no see, ssnjr2002
I hope you're doing well

I noticed that the addon doesn't show titles that have apostrophes or dots, like "Ron's Gone Wild (2021)" and "What If...? (2021)"

a) Ron's Gone Wild (2021)
1- Rons.Gone.Wrong.2021.2160p.UHD.BluRay.REMUX.HDR.HEVC.Atmos-PiRaTeS.mkv
2- [MF] Rons.Gone.Wrong.2021.720p.BluRay.x265.10Bit-Pahe.mkv
3- Ron's.Gone.Wrong.2021.1080p.DSNP.ENG.WEB-DL.DDP5.1.HEVC.x265-Archie.mkv
4- Ron's Gone Wrong (2021) (2160p BluRay x265 10bit HDR Tigole).mkv
None of these titles show up

b) What If... ? (2021)
1- What If... (2021) - S01E01 - What If… Captain Cart… The First Avenger (1080p WEB-DL x265 Silence).mkv
2- What If…! - S01E01 - What If… Captain Carter Were The First Avenger WEBDL-1080p Proper.mkv
3- What.If.S01E01.iTA.ENG.HDR.2160p.WEB.HEVC.DDP5.1.h264-DENiED.mkv
4- What.If.S01E01.Captain.Carter.Were.The.First.Avenger.2160p.10bit.DSNP.WEB-DL.DDP5.1.HEVC-Vyndros.mkv
Only b1 and b2 show up.

I tried to solve this issue using the little experience I have with python, this is what I did to meta.py:
https://github.com/theghost970/stremio-gdrive/blob/e7c8abd900f1ee4069cad54bbdb6cd73395f3a31/sgd/meta.py#L69-L77

However, this solution is not perfect:

  • With this solution, it is able to show a1 and a2, but it's unable to show a3 and a4.
  • It is able to show everything in section b, but it introduced a new problem: Irrelevant results are showing up in case of "removing dots", those titles are:

1- The Secrets She Keeps - S01E01 - Episode 1 WEBDL-1080p.mkv
2- Murder at the Cottage - The Search for Justice for Sophie - S01E01 - Episode 1 WEBDL-1080p.mkv
3- The Serpent (2021) - S01E01 - Episode 1 (1080p AMZN WEB-DL x265 Ghost).mkv
4- The Serpent - S01E01 - Episode 1 WEBDL-1080p.mkv

It is not a big issue tbh, just wanted to let you know in case you were free :)

@z8512
Copy link

z8512 commented May 13, 2022

Can you please add kitsu support?

https://github.com/TheBeastLT/stremio-kitsu-anime

@ssnjr2002
Copy link
Owner

Sorry for the late reply, I have a lot of stuff on my plate and my old pc died. Got a new one recently and just saw your issue. I will check into this issue as soon I got time, but not right now and maybe not for a while. Lot of academic work pending for me lol. I see you tried to fix it :) thats pretty cool. But I think the whole search and filter method needs to be redone, otherwise fixing one thing breaks another. I have no time to do it now tho :( Guess we leave this issue open for now, hope you understand.

@AlyafeiAli
Copy link
Author

Welcome back and congrats on your new pc!
No worries at all, and good luck with your academic work lol

@zDuts
Copy link

zDuts commented Sep 14, 2022

@AlyafeiAli did you ever find a good solution for this?

@AlyafeiAli
Copy link
Author

@AlyafeiAli did you ever find a good solution for this?

Nothing other than the one I linked in my post

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants