Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate use of a shadow jar for building fat executables #30

Closed
ssoper opened this issue Sep 12, 2021 · 1 comment · Fixed by #73
Closed

Investigate use of a shadow jar for building fat executables #30

ssoper opened this issue Sep 12, 2021 · 1 comment · Fixed by #73

Comments

@ssoper
Copy link
Owner

ssoper commented Sep 12, 2021

Currently overriding default JAR settings in the gradle file to build a fat executable which could interfere with future attempts to build a maven plugin. Use the ShadowJar gradle plugin to build a fat executable instead.

@ssoper
Copy link
Owner Author

ssoper commented Sep 14, 2021

Part of resolving this issue will involve breaking out command-line part of the app, currently in Core, into a "clients" package with E*TRADE being the first supported client. Also, rename RuntimeConfig to ClientConfig and possibly update the GlobalConfiguration to include everything needed so we don't have to pass verbose and production flags separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant