Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme suggests that SST can be used to deploy #36

Closed
JanStevens opened this issue Jan 31, 2023 · 2 comments
Closed

Readme suggests that SST can be used to deploy #36

JanStevens opened this issue Jan 31, 2023 · 2 comments

Comments

@JanStevens
Copy link
Contributor

Hi,

After a couple of confusing hours trying out open-next with SST, I noticed that SST does not use open-next at all, the page linked in the readme points to https://docs.sst.dev/constructs/NextjsSite where you see they depend on serverless-next.js dependency @sls-next/lambda-at-edge.

Looking at the Builder class used it does not use anything from open-next, you are basically deploying a serverless-next.js wrapper using SST.

Can the reference to SST be removed from the Readme? It now indicates that you can use SST for deployment but in fact it has nothing to do with open-next.

Regards,

@JanStevens
Copy link
Contributor Author

After some more digging it seems SST v2 will have support for open-next, maybe that should be indicated in the readme?

@khuezy
Copy link
Collaborator

khuezy commented Jan 31, 2023

Are you on the sst2 branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants