Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] rework backend + oversubscribe writer #12

Merged
merged 16 commits into from Aug 27, 2021

Conversation

sstadick
Copy link
Owner

  • Fix wording on thread allocation. num_threads now specifies how many compression threads to spawn and doesn't account for the writer thread since that can be oversubscribed.
  • Dropped rayon in favor of raw threads for performance
  • Made queue sizes larger

Overall, this version is faster and leaner than the previous version.

@sstadick sstadick changed the title Feature/allow oversubscribed writer [feature] rework backend + oversubscribe writer Aug 26, 2021
@sstadick sstadick linked an issue Aug 27, 2021 that may be closed by this pull request
@sstadick sstadick marked this pull request as ready for review August 27, 2021 20:39
@sstadick sstadick merged commit f7692a7 into main Aug 27, 2021
@sstadick sstadick deleted the feature/allow_oversubscribed_writer branch August 27, 2021 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gzp spawns one less threads than CPUs, which hurts performance
1 participant