Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on core_affinity crate #26

Closed
figsoda opened this issue Oct 31, 2021 · 7 comments
Closed

Remove dependency on core_affinity crate #26

figsoda opened this issue Oct 31, 2021 · 7 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@figsoda
Copy link

figsoda commented Oct 31, 2021

core_affinity is unmaintained (last update was 2 years ago, last real update was 4 years ago)

It links against System on macos as a framework, which is marked as "do not use" in apple's documentation: NixOS/nixpkgs#143861 (comment), and is causing darwin builds of crabz to fail in nixpkgs

Some possible alternatives I found: affinity

@sstadick
Copy link
Owner

sstadick commented Nov 1, 2021

@figsoda thanks for making an issue! Great point, I will look to move away from core_affinity ASAP / with the next release. I'm not sure when that's coming just yet, but it happen! PRs also welcome. core_affinity is only used in two spots and should be straightforward to swap out.

@sstadick sstadick added enhancement New feature or request good first issue Good for newcomers labels Nov 1, 2021
@figsoda
Copy link
Author

figsoda commented Nov 2, 2021

looks like affinity crate doesn't have get_core_ids 🤔

@sstadick
Copy link
Owner

Closing along with #37

Still could be nice to move off this, but I know have more of a relationship with the core_affinity author who did get things done when it needed to happen.

@figsoda
Copy link
Author

figsoda commented Jan 23, 2023

thanks for contacting!
do you mind asking them to take a look at this? Elzair/core_affinity_rs#17
I was just able to verify that the patch works as expected

@sstadick
Copy link
Owner

I've asked 👍

@figsoda
Copy link
Author

figsoda commented Jan 23, 2023

thanks!

@sstadick
Copy link
Owner

I believe it was resolved, I'll get another round our dependency updates in today at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants