Fix incorrect results from Array#intersect. [#841 state:resolved] (…

…Alexey Bass, Yaffle, Victor)
prototypejs · Mar 4, 2012 · 191f458 · 191f458
1 parent eac97a0
commit 191f458
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/prototype/lang/array.js b/src/prototype/lang/array.js
@@ -358,7 +358,7 @@ Array.from = $A;
   **/
   function intersect(array) {
     return this.uniq().findAll(function(item) {
-      return array.detect(function(value) { return item === value });
+      return array.indexOf(item) !== -1;
     });
   }
 

diff --git a/test/unit/array_test.js b/test/unit/array_test.js
@@ -131,6 +131,7 @@ new Test.Unit.Runner({
 
   testIntersect: function(){
     this.assertEnumEqual([1,3], [1,1,3,5].intersect([1,2,3]));
+    this.assertEnumEqual([0,1], [0,1,2].intersect([0,1]));
     this.assertEnumEqual([1], [1,1].intersect([1,1]));
     this.assertEnumEqual([], [1,1,3,5].intersect([4]));
     this.assertEnumEqual([], [1].intersect(['1']));