Short-circuit HAS_EXTENDED_CREATE_ELEMENT_SYNTAX #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HAS_EXTENDED_CREATE_ELEMENT_SYNTAX may be true only in IE8 and below (and is used only as a workaround for IE specific bug), so testing this feature in non-IE browsers doesn't have sense and only wastes time.
|
Probably, but the point of feature testing is that you don't trust the UA string and want to see for yourself. I'm closing this for now. I'm open to a reassessment of our feature testing strategy; but if we want a change in policy, best to do it all at once rather than piecemeal. Keep this in mind for 1.8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HAS_EXTENDED_CREATE_ELEMENT_SYNTAX may be true only in IE8 and below (and is used only as a workaround for IE specific bug), so testing this feature in non-IE browsers doesn't have sense and only wastes time.