Firefox 18+ supports String#startsWith, String#endsWith #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for writing this. This prevents us from clobbering the native version, but we should go further and make our existing If you don't feel like it, I'm happy to work on it myself when I get the time. |
|
Yes, I'll make it. |
added 2 commits
January 27, 2013 01:48
Added optional position argument to `String#startsWith`, `String#endsWith`, as described in https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Objects/String/startsWith and https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Objects/String/endsWith. Documented new arguments and examples.
|
Firefox has also String#contains, which is similar to Prototype's |
|
Review and pull, please. I've checked unit tests on Firefox 18.0.1 (with native implementation) and Chrome 24 (with our polyfill). |
savetheclocktower
added a commit
that referenced
this pull request
Mar 26, 2013
Use native `String#startsWith` and `String#endsWith` if present. Turn existing implementation into a true polyfill.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket https://prototype.lighthouseapp.com/projects/8886/tickets/1654-native-startswithendswith-in-firefox