Added standard Methods to SVG Elements #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://prototype.lighthouseapp.com/projects/8886/tickets/1655-include-svgand-others-elements-support added logic check and then standard Element.methods to SVGElement.prototype. Tested in IE9/IE10/Chrome/Firefox/Safari. In earlier IE without SVG support it fails silently
|
I'd prefer to keep this as an extension. Because |
|
Sounds good I'll put something together and document it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://prototype.lighthouseapp.com/projects/8886/tickets/1655-include-svgand-others-elements-support
I've added some changes to dom.js to add the standard methods to SVGElements, but didn't know if this was something to address.
I've tested on IE6-IE10 it fails silently on IE6-8 and works on IE9 and 10
also tested on Firefox/Chrome/Safari
If SVGElements should not have these methods or need a smaller set of methods I can do that too