Added standard Methods to SVG Elements #97

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@jwestbrook

https://prototype.lighthouseapp.com/projects/8886/tickets/1655-include-svgand-others-elements-support

I've added some changes to dom.js to add the standard methods to SVGElements, but didn't know if this was something to address.

I've tested on IE6-IE10 it fails silently on IE6-8 and works on IE9 and 10

also tested on Firefox/Chrome/Safari

If SVGElements should not have these methods or need a smaller set of methods I can do that too

@jwestbrook jwestbrook Added standard Methods to SVG Elements
https://prototype.lighthouseapp.com/projects/8886/tickets/1655-include-svgand-others-elements-support
added logic check and then standard Element.methods to SVGElement.prototype. Tested in IE9/IE10/Chrome/Firefox/Safari.
In earlier IE without SVG support it fails silently
6aaa68d
@savetheclocktower
Collaborator

I'd prefer to keep this as an extension. Because Element.Methods and Element.Methods.Simulated are public, you can write a separate script to mix them into SVGElement.prototype with only slightly more effort than in this PR.

@jwestbrook

Sounds good I'll put something together and document it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment