Fix #19 #20
Closed
Fix #19 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -57,8 +57,9 @@ sanitize-vars() { | |||
| -e "s/export \([A-Za-z_][0-9A-Za-z_]*\)?=/[ -n \"\$\\1\" ] || export \\1=/g" | |||
| } | |||
|
|
|||
| while read file; do | |||
| for file in $(find-rbenv-vars-files) | |||
| do | |||
There was a problem hiding this comment.
You should follow the current code style and put the do on the previous line
|
Hey, @mislav How is my last commit looking? :-) Any comments? |
|
Looking good, that's exactly how we do it in rbenv. You didn't necessarily have to restore old IFS there since the script is over there and doesn't eval any plugins itself, like rbenv does, so a changed IFS value isn't gonna affect anything. But, if anyone adds more code after that point it's going to save them, so no harm there. |
|
Kewl, thanks! 😸 |
|
@mislav, would you be able to merge this in? Or is there a different person to bug? 😈 |
|
I don't have push access to this repo, but @sstephenson does. |
mislav
added a commit
that referenced
this pull request
Nov 20, 2021
Fixes #19 Co-authored-by: Mislav Marohnić <git@mislav.net>
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19