Skip to content
This repository has been archived by the owner on Jun 10, 2018. It is now read-only.

Bower bower.json files support #582

Closed
mehlah opened this issue May 31, 2014 · 1 comment
Closed

Bower bower.json files support #582

mehlah opened this issue May 31, 2014 · 1 comment

Comments

@mehlah
Copy link

mehlah commented May 31, 2014

Hello folks,

I'm looking for your thoughts before a PR.
At the moment, sprockets looks only for a bower.json file for Bower installed packages, but nothing guarantees that file always exists, for example, Dropzone. Also for non-registry packages there will be .bower.json, but no bower.json (in cache too).

Bower always creates a .bower.json file based on bower.json with some additional properties used internally.

Why not looking for a .bower.json instead of bower.json? Isn't safer?
Or maybe better, looking for all possible names based on Bower specs https://github.com/bower/json/blob/master/lib/json.js#L7

A discussion ont he subject bower/bower#1174

Any thoughts?

@josh
Copy link
Contributor

josh commented May 31, 2014

It tried supporting it at one time, 1664c41, but it was reverted since . files are ignored.

For now, I think dropzone should fix their bower.json to not ignore itself.

https://github.com/enyo/dropzone/blob/master/bower.json#L12

@josh josh closed this as completed in da53aaf Jun 2, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants