Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing return warnings for GCC for switch statements #1255

Closed
jjwilke opened this issue Apr 8, 2019 · 6 comments
Closed

Missing return warnings for GCC for switch statements #1255

jjwilke opened this issue Apr 8, 2019 · 6 comments
Assignees
Milestone

Comments

@jjwilke
Copy link
Contributor

jjwilke commented Apr 8, 2019

Several switch statements do not provide a trailing return or default case statement, leading GCC to spew complaints about missing return statements in memOp.h, nicEvents.h, and shmemapi.h

@jjwilke jjwilke self-assigned this Apr 8, 2019
@jjwilke jjwilke added this to the SST 9.0 milestone Apr 8, 2019
@hughes-c
Copy link
Member

@jjwilke Should this go into 9.1?

@hughes-c hughes-c modified the milestones: SST 9.0, SST v9.1.0 Aug 6, 2019
@jwilso
Copy link
Contributor

jwilso commented Oct 21, 2019

@jjwilke @hughes-c Was this ever addressed? I will leave it open if so.

@hughes-c
Copy link
Member

@jwilso Not that I'm aware of.

@allevin allevin modified the milestones: SST v9.1.0 , SST v11.0.0 Oct 14, 2020
@nmhamster
Copy link
Contributor

@allevin / @jjwilke - do we have a list of these we can knock out for the release?

@allevin
Copy link
Contributor

allevin commented Feb 19, 2021

@jjwilke do you know what version of the gcc compiler was throwing the complaints?
I will try to do a warnings scrub next week.

@allevin
Copy link
Contributor

allevin commented Apr 7, 2021

@jjwilke @nmhamster I cannot reproduce these build warnings. I tried GCC 4.8 and GCC 6.1... The issue was submitted in 2019, and may have been cleaned up since. I recommend closing.

@hughes-c hughes-c closed this as completed Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants