Feature request: text-decoration underline style / <ins> Element

[skolmer]

Please add a button to set underlined text.

[sstur]

I had this in the past but I removed it for some reason that I can't remember now. There is some opinion that underline as a style should not be used in documents except for in links. This is because users have been conditioned to expect underlined text to be a link.

I am happy to add this back in and make it optional. This means we need a prop to customize the toolbar. So this feature request depends on #72.

[skolmer]

Sounds reasonable. Underline is a requirement in my current project but I understand that this can lead to bad UX. If you are adding customization features to the toolbar please consider to add className props for toolbar buttons. This will make it easier to change icons or add styling like bootstrap's button styles.

[Calyhre]

Actually, this is not removed. If you paste underlined text, it will produce ++text++ in markdown, which does not exists in any markdown syntax.

[sstur]

which does not exists in any markdown syntax.

I do believe there are flavors of markdown that support ++text++ (although I can't think of any at the moment) but you are right it is not really vaid markdown. The alternative is adding <ins> HTML tag in the markdown which is supported by many more parsers (including github flavored markdown). But I really don't like putting arbitrary html in markdown.

Anyway, I'm undecided as to what's the right thing to do with pasted styles like this. I suppose there should be an option that lets you specify what to allow during pasting and for everything that's not included just strip the styles completely.

Thoughts?

[Calyhre]

Yeah, might be a good idea!

The main issue here, is draft-js not allowing us to whitelist pasted inline styles.
There is an issue for this facebookarchive/draft-js#166

[skolmer]

Fixed in #72