Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

visitor context hooks #21

Open
7 of 10 tasks
ssube opened this issue Jul 2, 2019 · 0 comments
Open
7 of 10 tasks

visitor context hooks #21

ssube opened this issue Jul 2, 2019 · 0 comments
Assignees
@ssube
Labels
scope/visitor status/progress issues that are in progress type/feature
Milestone
v0.9

Comments

@ssube
Copy link
Owner

ssube commented Jul 2, 2019 •
edited

Add hooks to the visitor context so callers can be notified at various important times, including:

  • item:
    • check (start)
    • skip (end - skip)
    • visited (start)
    • diff (mid - block)
    • error (end - fail)
    • pass (end - pass)
  • rule:
    • visited (start)
    • error (end - fail)
    • pass (end - pass)

Along the way:

  • push error formatting up to the hooks
@ssube ssube self-assigned this Jul 2, 2019
@ssube ssube added scope/visitor status/planned issues that have been planned but not started type/feature labels Jul 2, 2019
This was referenced Jul 2, 2019
Closed
Open
@ssube ssube added this to the v0.9 milestone Nov 2, 2019
This was referenced Nov 10, 2019
Open
Open
Closed
@ssube ssube mentioned this issue Nov 19, 2019
Closed
@ssube ssube added status/progress issues that are in progress and removed status/planned issues that have been planned but not started labels Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ssube ssube

Labels
scope/visitor status/progress issues that are in progress type/feature
Projects
None yet
Milestone
v0.9
Development

Successfully merging a pull request may close this issue.

WIP: emit visitor events ssube/salty-dog
1 participant
@ssube