Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

string search should not loop over state twice #44

Closed
ssube opened this issue May 16, 2021 · 0 comments
Closed

string search should not loop over state twice #44

ssube opened this issue May 16, 2021 · 0 comments
Assignees
@ssube
Labels
scope/state world state management status/progress issues that are in progress type/bug
Milestone
v1.2

Comments

@ssube
Copy link
Owner

ssube commented May 16, 2021

The state string search (for id or name) currently merges a pair of sub-searches, one each for the id and name fields.

Duplicating some of the search logic, or implementing a generic state walker, will allow that to be reduced into a single loop.
@ssube ssube added status/new issues that have not been addressed yet type/bug scope/state world state management labels May 16, 2021
@ssube ssube added this to the v1.2 milestone May 16, 2021
@ssube ssube self-assigned this May 16, 2021
@ssube ssube mentioned this issue May 18, 2021
Closed
@ssube ssube added status/progress issues that are in progress and removed status/new issues that have not been addressed yet labels May 19, 2021
@ssube ssube closed this as completed in a305361 May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ssube ssube

Labels
scope/state world state management status/progress issues that are in progress type/bug
Projects
None yet
Milestone
v1.2
Development

No branches or pull requests
1 participant
@ssube