Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter shown messages by focus and scope #67

Closed
ssube opened this issue May 23, 2021 · 0 comments
Closed

filter shown messages by focus and scope #67

ssube opened this issue May 23, 2021 · 0 comments
Assignees
Labels
scope/state world state management status/fixed issues that have been fixed and confirmed type/feature
Milestone

Comments

@ssube
Copy link
Owner

ssube commented May 23, 2021

When a script calls focus.show with a message, it may not be for the player: it could be for the current actor, everyone in the room, or (in the case of an item script) the actor currently holding an item. The player should not receive output meant for NPCs in other rooms, especially in a network scenario.

Pass the intended scope into focus.show, replacing the optional source with an optional scope: {source, target}. Valid targets include self, room, and world.

A container target would be cool (the actor holding this item, or room containing this actor), but depends on #53 .

@ssube ssube added type/feature scope/state world state management labels May 23, 2021
@ssube ssube added this to the v1.3 milestone May 23, 2021
@ssube ssube self-assigned this May 23, 2021
@ssube ssube added the status/new issues that have not been addressed yet label May 23, 2021
@ssube ssube closed this as completed in 3b1637f May 27, 2021
@ssube ssube added status/fixed issues that have been fixed and confirmed and removed status/new issues that have not been addressed yet labels May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/state world state management status/fixed issues that have been fixed and confirmed type/feature
Projects
None yet
Development

No branches or pull requests

1 participant