-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breaking changes for 1.0.0 #36
Comments
We are using As you mentioned the html mode would end in something like a WYSIWG Editor, which is an overkill. If there is no other voice I think dropping the html support will be the right thing to do. There are so many well done WYSIWG solutions. |
@iNaD thank you for the feedback. We just released
This enables us to significantly reduce the complexity of this addon as we now are able to rely on the browser to handle the modification of the dom and we only need to make sure to keep the binding of the provided property in sync. This should eliminate any potential bugs resulting from earlier custom implementations of key and copy-paste handlers as well as modifying the caret position. We encourage anybody to test the prerelease and let us know about any findings here. Demo page of the current alpha.1 release is available here |
|
key-press/key-up event handlers seemingly not functioning on |
I think this has been in a pre-release state long enough for now and any critical issues should be resolved by now. Finally releasing 1.0.0. |
As already introduced in the readme, the 1.0.0 release will remove any currently deprecated apis. In addition to that I am considering removing the html support which is enabled by setting type to
html
. The reasons behind this are as following:In the end, there are a lot of things that can be build by setting contenteditable on an element, which are rather hard to support by a very general addon. By putting a clear focus on being a flexible replacement for input and textarea elements I think we will be able to ship a much more stable addon, which works the way people are expecting it to work. I think anything that previously relied on the html type will find a much better place in dedicated addons than with one that tries to do it all.
Please raise your concerns, as I don't want to break this addon for a lot of people just because I wasn't able to think about that one use case that totally makes sense.
The text was updated successfully, but these errors were encountered: