Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: the number of val/test data is not consistent with other cases when the same years are selected for train_year and test_year. #206

Closed
wildsnowman opened this issue Sep 22, 2022 · 0 comments · Fixed by #207
Closed

Bug: the number of val/test data is not consistent with other cases when the same years are selected for train_year and test_year. #206

wildsnowman opened this issue Sep 22, 2022 · 0 comments · Fixed by #207
Assignees
@wildsnowman
Labels
bug Something isn't working

Comments

@wildsnowman
Copy link
Collaborator

Describe the bug
In set matching, the numbers of data used are restricted as 30816, 3851, and 3851 for train, val, and test data, respectively; however, when the same years are selected for train_year and test_year, it will be inconsistent.

This bug may cause inappropriate experiments in changing train_year and test_year.
@wildsnowman wildsnowman added the bug Something isn't working label Sep 22, 2022
@wildsnowman wildsnowman self-assigned this Sep 22, 2022
@wildsnowman wildsnowman linked a pull request Sep 22, 2022 that will close this issue
making consistent data sizes #207
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wildsnowman wildsnowman

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

making consistent data sizes st-tech/zozo-shift15m
1 participant
@wildsnowman