Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve usage of Streamable in repositories #293

Closed
odrotbohm opened this issue Dec 10, 2019 · 0 comments
Closed

Improve usage of Streamable in repositories #293

odrotbohm opened this issue Dec 10, 2019 · 0 comments
Assignees
@odrotbohm
Labels
type: enhancement Improvements and new features
Milestone
7.3

Comments

@odrotbohm
Copy link
Member

odrotbohm commented Dec 10, 2019 •
edited

  • findAll() should be redeclared to return Streamable
  • Inventory should declare a streamAll() to also return a Streamable<InventoryItem<?>> for composability of results from UniqueInventory and MultiInventoryItem
@odrotbohm odrotbohm added this to the 8.0 milestone Dec 10, 2019
@odrotbohm odrotbohm self-assigned this Dec 10, 2019
@odrotbohm odrotbohm changed the title Redeclare Catalog.findAll() to return Streamable Improve usage of Streamable in repositories Dec 11, 2019
odrotbohm added a commit that referenced this issue Dec 11, 2019
@odrotbohm
#293 - Improvements to Salespoint repository declarations.
3c8498c 
Introduced SalespointRepository to consistently override CrudRepository.findAll() to return a Streamable<T>. Inventory also got a Streamable<InventoryItem<?>> streamAll() returning the common super type for easy composability via Streamable.and(…) in case results from both UniqueInventory and MultiInventory.

Updated all client services to avoid re-wrapping into a Streamable that was necessary before.
odrotbohm added a commit that referenced this issue Dec 11, 2019
@odrotbohm
#293 - Polishing.
b2dea0d
@odrotbohm odrotbohm added the type: enhancement Improvements and new features label Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
type: enhancement Improvements and new features
Projects
None yet
Milestone
7.3
Development

No branches or pull requests
1 participant
@odrotbohm