Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OrderManagement.save(…) updates order creation date under the wrong condition #338

Closed
martinmo opened this issue Dec 15, 2020 · 0 comments
Closed

OrderManagement.save(…) updates order creation date under the wrong condition #338

martinmo opened this issue Dec 15, 2020 · 0 comments
Assignees
@odrotbohm
Labels
module: orders Orders prio: 2 - medium Medium priority issues type: bug Bugs
Milestone
7.4

Comments

@martinmo
Copy link
Contributor

See https://github.com/orgs/st-tu-dresden-praktikum/teams/all-members/discussions/25.

Probably, in commit f5af4d91 the if statement was changed erroneously to the opposite.
@martinmo martinmo added type: bug Bugs module: orders Orders prio: 2 - medium Medium priority issues labels Dec 15, 2020
@odrotbohm odrotbohm self-assigned this Dec 17, 2020
@odrotbohm odrotbohm added this to the 7.4 milestone Dec 17, 2020
odrotbohm added a commit that referenced this issue Dec 17, 2020
@odrotbohm
#338 - Fixed application of business time to orders.
d3dee69 
Introduced with f5af4d9, we erroneously applied business time to non-new orders, when the actual intention was to initially override the creation date held in Order with the value provided by BusinessTime.
@odrotbohm odrotbohm changed the title OrderManagement.save() updates dateCreated under the wrong condition OrderManagement.save(…) updates order creation date under the wrong condition Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
module: orders Orders prio: 2 - medium Medium priority issues type: bug Bugs
Projects
None yet
Milestone
7.4
Development

No branches or pull requests
2 participants
@odrotbohm @martinmo