Adjust the height for item text to prevent DPI issue

[BoredOutOfMyGit]

I was unable to replicate this issue while using a regular user app but when in
use with AOSP, I noticed an issue when adjusting font size to anything above 'Default'.

Test:

• Import aar to AOSP
• Utilize the library
• Adjust the font size to Large or above under Settings

See image to notice issue described above

• https://i.imgur.com/zm4s2mz.jpg

[st235]

Hi @BoredOutOfMyGit 👋

First of all, thanks for using this library and mostly for the contribution. I very appreciate it!
I try to keep the behaviour of this widget consistent to native BottomNavigationBar. Of course, the text should be scaled.

I made a small research, and you were right - its really possible text view would be trimmed by image view height when used upscaled font size. It was a nice catch, thank you.

With MATCH_PARENT height

With WRAP_CONTENT height

As you can see, u've made a great research, but small thing should be done here - now ImageView is not centred at menu item. I will fix it in separate PR.

Hopefully, you will make other important discoveries further. Thanks

[BoredOutOfMyGit]

Thank you! I look forward to seeing the PR for centering the imageview as well :)

I'll definitely report any issues I come across and if possible, submit PR's to fix said issues.

Keep up the good work! I love this library!

[st235]

1.1.6 live now
This version contains fixes related to the problem