Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] image scaling on mobile #953

Open
dengrish opened this issue May 9, 2024 · 2 comments
Open

[FEAT] image scaling on mobile #953

dengrish opened this issue May 9, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@dengrish
Copy link

dengrish commented May 9, 2024

ISSUE

I have many flashcards that include images. When I create them on a desktop computer, I set appropriate width using the bar |.

Example: ![[Pasted image 20240508142713.png|350]].

When I later review the flashcards on a smartphone, those images typically turn out to be too wide requiring horizontal scrolling. This makes reviewing on a smartphone inconvenient.


PROPOSED SOLUTION

When flashcards are reviewed on a smartphone, the bar that sets image width should be ignored so that image width is fit to the width of the screen.

Example: Image ![[Pasted image 20240508142713.png|350]] would be displayed as ![[Pasted image 20240508142713.png]] (removing "|350").

@dengrish dengrish added the enhancement New feature or request label May 9, 2024
@ronzulu
Copy link
Collaborator

ronzulu commented May 9, 2024

Hi @dengrish thanks for the suggestion.

Would there be cases where this would not be wanted? Do you think it would need to be an option for users?

Or maybe conditional, e.g. only where the specified width is greater than a configurable constant?

Cheers
Ronny

@dengrish
Copy link
Author

Yes. I think there should be an option:

  1. Show images using widths as specified (number after |).
  2. Ignore the specified widths to scale images to the width of the screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants