#203 added EQUALS_FAST and HASH_CODE_FAST #205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 26, 2017 21:37
Now it is possible to test equals() and hashCode() in quadratic rather than exponential time (and 20^2 is much better than 2^20 for a POJO with 20 fields corresponding to 20 columns in a DB table). The old thorough testers are preserved.
sta-szek
requested changes
Aug 31, 2017
| } | ||
|
|
||
| // @TestFactory | ||
| // public Stream<DynamicTest> Should_Generate_Different_Objects_Recursively() throws IllegalAccessException { |
There was a problem hiding this comment.
remove those tests or make them pass
| @Test | ||
| public void Should_Generate_Different_Objects_For_Class_Containing_Boolean_Type() { | ||
| // given | ||
| final ObjectGenerator objectGenerator = new ObjectGenerator(abstractFieldValueChanger, constructorParameters); | ||
| final ObjectGenerator objectGenerator = makeObjectGenerator(abstractFieldValueChanger, constructorParameters); |
There was a problem hiding this comment.
Remove parameters abstractFieldValueChanger and constructorParameters as they are always the same.
|
|
||
| public HashCodeFastTester() { | ||
| super(); | ||
| setThoroughTesting(false); |
There was a problem hiding this comment.
https://stackoverflow.com/a/3404369
You can create protected constructor in HashCodeTester with boolean parameter and then call super(true)
Same in EqualsFastTester
|
|
||
| public ObjectGenerator(final AbstractFieldValueChanger abstractFieldValueChanger, | ||
| final MultiValuedMap<Class<?>, ConstructorParameters> constructorParameters) { | ||
| final MultiValuedMap<Class<?>, ConstructorParameters> constructorParameters, | ||
| final boolean thorough) { |
There was a problem hiding this comment.
It would be better to pass some kind of policy, that would generate fields / list of fields e.g.
interface Permutator { public List<List<T>> permutate(final List<T> listToPermutate);}
class ThoroughFieldPermutator implements Permutator {}
class SublistFieldPermutator implements Permutator {}
|
I think that the second approach is better. |
ghost
removed
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it is possible to test equals() and hashCode() in quadratic rather
than exponential time (and 20^2 is much better than 2^20 for a POJO
with 20 fields corresponding to 20 columns in a DB table).
The old thorough testers are preserved.