Skip to content
This repository has been archived by the owner on Apr 19, 2023. It is now read-only.

Feature: Check input against regular expression #115

Closed
cloudkompute opened this issue Jul 5, 2019 · 7 comments
Closed

Feature: Check input against regular expression #115

cloudkompute opened this issue Jul 5, 2019 · 7 comments

Comments

@cloudkompute
Copy link

Regular expressions could be for Name (only alpha letters), Password (strong password with special characters, minimum length), Domain name (occurrence of dot) etc.

Better if we display the Password Strength meter.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.96. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@AnandChowdhary
Copy link
Member

Do you mean this for the frontend? If yes, maybe it's a better idea to open this issue in the Staart UI repository, since this is primarily the backend and build tools.

@AnandChowdhary
Copy link
Member

We currently do validate using the internal validator helpers. The rule (I think) is name should be a string of at least 3 characters, and password/domain should be strings. I didn't want to be too strict with the password rules, but it's something I will look into. Thanks again for opening these issues!

@cloudkompute
Copy link
Author

@AnandChowdhary Thx. for the detailed replies.

Yes, the validations should be applied at both the ends i.e. UI and backend. So probably, you may create a common/validators folder and share the code.

@AnandChowdhary
Copy link
Member

@all-contributors can you please add @coooolers for bugs and ideas?

@allcontributors
Copy link
Contributor

@AnandChowdhary

I've put up a pull request to add @coooolers! 🎉

@AnandChowdhary
Copy link
Member

I've added better validation for names (alphabet and space), passwords (minimum length), and domains (regex).

@AnandChowdhary AnandChowdhary added this to Done in Staart Mar 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Staart
  
Done
Development

No branches or pull requests

2 participants