-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for C in tools.cmake #46
Comments
I committed c1a621a, which I think covers it. let me know if there's still an issue. |
Thank you, that looks good. Though I am curious about the intended behavior of the cppcheck logic in |
Honestly, I'm not entirely sure anymore. Much of the implementation is several years old. However, as you do note it was a bit confusing, so I've gone ahead and re-worked the implementation (ba83421), and hopefully made things much clearer. I've gone fully down the road of giving better control of the tools to the calling scripts, and the ability to overwrite/clear flags at-will throughout. Let me know if what it is now is still unclear, or what parts of it are, and I'll try to fix/make things even clearer. |
All the tools in
tools.cmake
are currently applied to only C++ code, however they all support C code as well. Supporting C should just be a fairly straightforward -- for example setting theCMAKE_C_CLANG_TIDY
to matchCMAKE_CXX_CLANG_TIDY
The text was updated successfully, but these errors were encountered: