This repository has been archived by the owner on Mar 18, 2021. It is now read-only.
API reference documentation and some name changes #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeconwaystk
force-pushed
the
jc/api_and_doc
branch
from
e45895f
to
97298b3
Compare
|
Are there any non-name changes? Github chokes on this diff |
|
Well, name changes and API docs. If you checkout this branch and run dartdoc, then open doc/api/index.html, you'll see the full breadth of the changes |
|
👍 from me |
|
The only one I'm not sure about is |
|
Really? Why? That was the one I was most sure of. Not saying I'm right, but interested as to why |
|
Well set implies to me an unordered collection, but it looks like it would preserve order. |
|
Also set implies uniqueness which isn't necessary here. |
|
Well actually it is unique, but the ordered thing still bugs me. |
|
Well it is unique, but also there is no order - it'll be in the order the database decides. It may even be a subset. |
|
Ok in that case I'm fine with it, 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the size. Changed a lot of names to make the API more discoverable. Adding documentation for aqueduct classes and methods. This branch needs to be rebased after #91 is merged.