Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

urllib3 release breaks tests #509

Open
jsignell opened this issue May 4, 2023 · 4 comments · May be fixed by #517
Open

urllib3 release breaks tests #509

jsignell opened this issue May 4, 2023 · 4 comments · May be fixed by #517

Comments

@jsignell
Copy link
Member

jsignell commented May 4, 2023

It looks like urllib3 2.0.2 was released yesterday and it seems to be causing the tests to fail: #508

It might be related to psf/requests#6432 or something else
@gadomski
Copy link
Member

gadomski commented May 4, 2023

I think it's just this? kevin1024/vcrpy#688 (comment)

Latest requests supports urllib3: https://github.com/psf/requests/releases/tag/v2.30.0

@jsignell
Copy link
Member Author

jsignell commented May 4, 2023

Nice sleuthing. So we just wait with faiing tests or should we pin around it temporarily with the understanding that we will not release with a ceiling?

@gadomski gadomski mentioned this issue May 4, 2023
Merged
5 tasks
@gadomski
Copy link
Member

gadomski commented May 4, 2023

LOL I was in the process of writing #480 (comment), let's ceil and move along.

@jsignell
Copy link
Member Author

jsignell commented May 4, 2023

Leaving this open to track reverting #508 before release.

@jsignell jsignell added this to the 0.7.0 milestone May 4, 2023
@jsignell jsignell linked a pull request May 15, 2023 that will close this issue
Draft
3 tasks
@gadomski gadomski removed this from the 0.7.0 milestone Jun 7, 2023
@gadomski gadomski linked a pull request Aug 21, 2023 that will close this issue
Unpin urllib3 in dev dependencies #517
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unpin urllib3 in dev dependencies jsignell/pystac-client
2 participants
@gadomski @jsignell