Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download all assets #89

Closed
m-mohr opened this issue Aug 25, 2021 · 3 comments
Closed

Download all assets #89

m-mohr opened this issue Aug 25, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@m-mohr
Copy link

m-mohr commented Aug 25, 2021

Once I've found some data using the search command, I'd like to download all assets. It would be a nice convenience functionality to add so that people don't need to fiddle around with fs libraries themselves.

@matthewhanson
Copy link
Member

@gadomski and I discussed today. It seems a reasonable thing to expect PySTAC to support via the same STAC_IO mechanism, allowing other libraries to override to allow downloading using other protocols (e.g., s3).

By default this could support simple http requests. Recommend adding this as a PySTAC issue. Clients could then override this to support downloading using e.g., fsspec.

@gadomski gadomski added this to the 0.4.0 milestone May 31, 2022
@philvarner philvarner modified the milestones: 0.4.0, 0.5.0 Jun 3, 2022
@gadomski gadomski modified the milestones: 0.5.0, 0.6.0 Aug 30, 2022
@gadomski gadomski added the enhancement New feature or request label Nov 9, 2022
@gadomski gadomski modified the milestones: 0.6.0, 0.7.0 Jan 27, 2023
@gadomski gadomski removed this from the 0.7.0 milestone May 4, 2023
@gadomski
Copy link
Member

gadomski commented Jun 20, 2023

N.B. I've created a separate library for this behavior here: https://github.com/gadomski/stac-asset. Once I release v0.1 of stac-asset, I plan on moving it to https://github.com/stac-utils, and we can could/should this issue in favor of that library.

Reasons why I thought a separate library was appropriate:

  • stac-asset is async-first, which is pretty key for downloading a bunch of assets at once
  • There's some vendor- and implementation-specific logic required to do multi-provider asset-download support. This logic might require more frequent updates than is appropriate for a "base" library like pystac-client.
  • stac-asset's CLI is currently built to work well w/ pystac-client's CLI output, e.g.:
stac-client search http://stac-api.test -c foo --max-items 10 | stac-asset download

@gadomski
Copy link
Member

Ok, we're moved to stac-utils, so I'm closing this issue as complete-via-other-repo: https://github.com/stac-utils/stac-asset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants