Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging Resource Design #261

Closed
Tracked by #202 ...
fhennig opened this issue Sep 8, 2022 · 4 comments · Fixed by stackabletech/documentation#301
Closed
Tracked by #202 ...

Logging Resource Design #261

fhennig opened this issue Sep 8, 2022 · 4 comments · Fixed by stackabletech/documentation#301
Assignees

Comments

@fhennig
Copy link
Member

fhennig commented Sep 8, 2022

This is part of this epic: #202

This ticket is about deciding how existing resources (DruidCluster, NifiCluster etc) should be modified and if we want additional CRDs that possibly should be referenced, like we do with S3Buckets.

Things that the ADR should specify:

  • logging architecture and aggregation architecture (Decide about log agent architecture #259)
    • vector sidecar
    • vector aggregator - interchangable by the customer
    • opensearch dashboards - interchangable by the customer
  • common "stackable log format"
    • timestamp, log level, message
    • what else? additional information added by vector?
      • sidecar is probably part of what we offer, can't be modified
    • this is our default, but the customer can supply their own log4j file if they want to
  • common CRD fragment
  • A log level should be configurable in the product already. I.e. don't log at DEBUG by default and filter later; that's too costly
  • Log rotation should be used, logs can be discarded after vector has read them.
  • stackable/logs/* is an emptyDir so it can be shared between containers (product and agent)

Open questions:

  • Which things should be configurable and at which granularity?
  • Log line metadata: everything is exported, and the user can't change this. (which pod, which role, timestamp, log message)?

Extra things to consider

  • If the opensearch sink is unavailable, logs might be lost eventually
  • It would be great but not strictly mandatory if we could support the hyperscaler log collectors
    • e.g. Google has "Cloud Logging" which uses fluentbit
    • do not spend more than half a day researching this please
@lfrancke
Copy link
Member

Is this the ticket which defines the CRD layout for logging stuff?

@fhennig
Copy link
Member Author

fhennig commented Sep 14, 2022

Yes, I've updated the description to clarify this

@lfrancke
Copy link
Member

lfrancke commented Oct 9, 2022

The result of this should be an ADR but it should not overlap with the ADR from #259

@lfrancke
Copy link
Member

I've added one more point at the end, otherwise looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants