Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: Consolidate authentication #434

Closed
wants to merge 75 commits into from
Closed

[Merged by Bors] - feat: Consolidate authentication #434

wants to merge 75 commits into from

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Jun 15, 2023 •
edited
Loading

Description

Changed authentication to list of authentication classes.

Multiple authentication providers can be used (file, ldap). Hot reloading works.

test: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/trino-operator-it-custom/70/

fixes: #401

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Edit tasklist title
Beta Give feedback Tasklist Author, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Changes are OpenShift compatible
    Options
  2. CRD changes approved
    Options
  3. Helm chart can be installed and deployed operator works
    Options
  4. Integration tests passed (for non trivial changes)
    Options
Loading

Reviewer

Edit tasklist title
Beta Give feedback Tasklist Reviewer, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Code contains useful comments
    Options
  2. (Integration-)Test cases added
    Options
  3. Documentation added or updated
    Options
  4. Changelog updated
    Options
  5. Cargo.toml only contains references to git tags (not specific commits or branches)
    Options
Loading

Acceptance

Edit tasklist title
Beta Give feedback Tasklist Acceptance, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Feature Tracker has been updated
    Options
  2. Proper release label has been added
    Options
Loading

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander requested a review from a team June 15, 2023 13:36
@maltesander maltesander self-assigned this Jun 15, 2023
@sbernauer
Copy link
Member

Started test https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/trino-operator-it-custom/75/

@sbernauer sbernauer changed the title Consolidate authentication feast: Consolidate authentication Jun 29, 2023
@sbernauer sbernauer changed the title feast: Consolidate authentication feat: Consolidate authentication Jun 29, 2023
@sbernauer
Copy link
Member

Hopefully last test run: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/trino-operator-it-custom/76/

maltesander
maltesander commented Jun 29, 2023
View reviewed changes
rust/crd/Cargo.toml Outdated Show resolved Hide resolved
rust/crd/src/lib.rs Outdated Show resolved Hide resolved
rust/operator-binary/Cargo.toml Outdated Show resolved Hide resolved
sbernauer and others added 4 commits June 29, 2023 21:24
@sbernauer
Copy link
Member

The one and only https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/trino-operator-it-custom/77/

@sbernauer
Copy link
Member

bors r+
Tests passed 🚀

@bors
Copy link
Contributor

bors bot commented Jul 3, 2023

👎 Rejected by code reviews

sbernauer
sbernauer approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving together with Malte, as we have both written parts of this PR

@sbernauer
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jul 3, 2023
@maltesander @sbernauer
feat: Consolidate authentication (#434)
2cbe1af 
# Description

Changed authentication to list of authentication classes.

Multiple authentication providers can be used (file, ldap). Hot reloading works.

test: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/trino-operator-it-custom/70/

fixes: #401



Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jul 3, 2023

Pull request successfully merged into main.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: Consolidate authentication [Merged by Bors] - feat: Consolidate authentication Jul 3, 2023
@bors bors bot closed this Jul 3, 2023
@bors bors bot deleted the consolidate-authentication-crd branch July 3, 2023 13:50
@sbernauer sbernauer mentioned this pull request Jul 21, 2023
Closed
bors bot pushed a commit that referenced this pull request Jul 25, 2023
@sbernauer
fix: Let controller watch AuthenticationClasses (#449)
dbe81a6 
# Description

leftover of #434
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razvan razvan razvan left review comments

@github-actions github-actions[bot] github-actions left review comments

@sbernauer sbernauer sbernauer approved these changes

Assignees

@maltesander maltesander

@sbernauer sbernauer

Labels
changelog/breaking Breaking changes changelog/crd-change Any issue that changes a CRD (breaking and non-breaking changes) should get this label changelog/highlight Items worth mentioning in the Platform changelog release/2023-07
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rework Trino TLS / Auth structs: Change authentication to list of AuthenticationClasses
3 participants
@maltesander @sbernauer @razvan