Fix discovery of Go direct dependencies #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wescarr
commented
Sep 4, 2022
wescarr
commented
- Instead of relying on main.go existing in root directory we use go list to list the direct dependencies and then continue with the existing approach to get indirect dependencies
- Instead of relying on main.go existing in root directory we use go list to list the direct dependencies and then continue with the existing approach to get indirect dependencies
wescarr
changed the title
- Our current approach relied on a main.go file residing at the root of the repository which may not always be the case.
- Additionally calling go list {{.Deps}} module would not always give indented results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.