Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install packages that are hosted on github #36

Closed
ThomasBurleson opened this issue Aug 5, 2017 · 16 comments
Closed

Install packages that are hosted on github #36

ThomasBurleson opened this issue Aug 5, 2017 · 16 comments

Comments

@ThomasBurleson
Copy link

ThomasBurleson commented Aug 5, 2017

I want to use the nightly build of @angular/flex-layout.

Normally I can do one of these:

  • npm -i github.com/angular/flex-layout-builds, or
  • npm -i angular/flex-layout-builds

None of these seem to work in the StackBlizt IDE.

screen shot 2017-08-05 at 6 56 27 pm

Our deployment repos is www.github.com/angular/flex-layout-builds

@EricSimons
Copy link
Member

We currently only support importing from NPM, but we do have (basic) import from github working in local builds. However, it's gonna require a lot of testing & love to ensure it plays nice with our dep resolver, which is important bc we def don't want dep mismatches throwing errors in your console that you normally wouldn't get locally.

(PS - I just saw/responded to your tweet about this! 🍻)

@EricSimons EricSimons changed the title How to Install nightly builds Install packages that are hosted on github Aug 6, 2017
@ThomasBurleson
Copy link
Author

Understood. FYI.

Plz consider this an important feature: developers will use StackBlitz to test and demo... often with libraries recently fixed (e.g. nightly builds).

Consider me a volunteer for testing. ;-)

@ThomasBurleson
Copy link
Author

@EricSimons - If you guys need extra help with StackBlitz, ping me (I would love to get involved).

@EricSimons
Copy link
Member

Plz consider this an important feature: developers will use StackBlitz to test and demo... often with libraries recently fixed (e.g. nightly builds).

Excellent point, I hadn't even considered this. I'm gonna bump the priority on this feature to ensure it's in prod by EOM 👍

Def would love to have you get involved with SB! I'm putting together a list of things we could use help with actually, hoping to get it posted on the repo this week. Also just followed you on twitter so we can DM :)

@EricSimons EricSimons added bug and removed bug labels Aug 7, 2017
@ThomasBurleson
Copy link
Author

@EricSimons - ping me on email (github profile), let me when/how I can help. Cheers.

@ThomasBurleson
Copy link
Author

ThomasBurleson commented Sep 26, 2017

@EricSimons - I am still blocked with this. I would like to help resolve this one!

Did I miss a DM or email from you perhaps ?

@EricSimons
Copy link
Member

@ThomasBurleson so sorry about the delay here! Past month or so has been insane 😓 I'm going to start working on this today and will have it out early tmrw. Will post back here once it's live!

@ThomasBurleson
Copy link
Author

@EricSimons - wonderful news. Consider me a fan and a resource !

@EricSimons
Copy link
Member

@ThomasBurleson it's live on prod! You can simply enter https://github.com/angular/flex-layout-builds (or for a specific version, https://github.com/angular/flex-layout-builds#2.0.0-beta.9-e461d17) to install from github :)

This is definitely a beta feature so lmk if you run into any issues! There are also some limitations right now (it won't resolve nested sub-packages in the github repo, etc) but lmk if that's a req for you and I'll prioritize some time to put in a fix for it.

PS - we're still getting our ducks in a row for the next week or two, but keep an eye out for an email from me reg getting involved w/ stackblitz :)

@ThomasBurleson
Copy link
Author

@EricSimons - I so admire professionalism and communication. Kudos to you for both. I will try this beta feature today. Thank you.

@ThomasBurleson
Copy link
Author

@EricSimons - Your fix(es) work wonderfully.

Here is a blitz with the latest code in our nightly build:

https://stackblitz.com/edit/angular-pu8pc6?file=app%2Ftest.component.ts

screen shot 2017-09-28 at 10 46 06 am

Closing as fixed!

@EricSimons
Copy link
Member

@ThomasBurleson No problem at all! Thanks for the kind words :) It's great to see everything is working well for the flex-layout demo. Btw I put the final touches on the resolution logic today (per #149 (comment)), so it's now possible to import SASS/CSS, nested packages, etc from github repos as well (here's a demo of the latest GH build of Ang Material w/ a custom theme: https://stackblitz.com/edit/angular-m9axcs?file=theme.scss)

@ThomasBurleson
Copy link
Author

@EricSimons - So I get the import SASS feature. That is cool. What is a import nested packages example ?

@100ideas
Copy link

100ideas commented Nov 5, 2019

@EricSimons this feature does not appear to be working. Here's a screenshot of the project you referenced: https://stackblitz.com/edit/angular-m9axcs?file=theme.scss

Screen Shot 2019-11-05 at 7 27 57 AM

@richardeschloss
Copy link

Hi this would be a very useful feature, is there any news on this?

@kc0tlh
Copy link
Collaborator

kc0tlh commented Aug 30, 2023

Tagging as related to #1195

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants