Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] When app is in failed import state, emitted bundles need to include/respect errors #6

Closed
dwaq opened this issue Aug 3, 2017 · 9 comments
Assignees

Comments

@dwaq
Copy link

dwaq commented Aug 3, 2017

Would be nice if there was a full log of the build available. I'm seeing an error but it's not helping me without additional context.
image
Specially the project I'm working at is https://stackblitz.com/edit/react-epqmud but opening that link just shows the default files, and not the files that I imported myself. Maybe there's an additional bug there?

@EricSimons
Copy link
Member

EricSimons commented Aug 3, 2017

How did you get this error? This typically happens when an npm dependency is unable to be fetched during an install (often caused by bad network connection, etc). It's supposed to be descriptive about what failed to fetch though, so I'm not quite sure what's up here.

More info on how this occurred would be 👌

PS - please excuse our bugs; this tech is super beta and we're working our tails off to squash them all 😓

@dwaq
Copy link
Author

dwaq commented Aug 3, 2017

I exported my project from here https://glitch.com/edit/#!/swift-crime and dropped the files into stackblitz. Then I manually added the dependencies from the package.json. I didn't see any errors as I typed them in, but it is possible something went wrong there.

Don't worry about the bugs. Just trying to make the product better by reporting them 😄

@dwaq
Copy link
Author

dwaq commented Aug 3, 2017

Are the dependencies fetched server side or client side? I'm behind a proxy now that usually gives me errors fetching packages locally but I assumed your application would grab them directly.

@EricSimons
Copy link
Member

We really, really appreciate you reporting the bugs — it absolutely helps us make the product better, so please keep them coming! ❤️ (Hopefully there shouldn't be too many haha)

The dependencies are actually fetched client side, so perhaps the proxy might be the problem. I'm going to try and download your glitch project, drag & drop into SB and see what happens. Currently swamped with the launch but I'll def repro this & nail down any issue by EOD 🙏

@EricSimons
Copy link
Member

^ will actually have to do this first thing tmrw morn- super super tired from all the launch stuff today 😴 Will report back when I've repro'd & ID root cause!

@dwaq
Copy link
Author

dwaq commented Aug 4, 2017

No rush. I was just playing around. Focus on what's important for getting this project off the ground. I'll come back when it's fixed. 👍

@EricSimons
Copy link
Member

@dwaq this was actually just a UI bug on our end 😅 was worried it was something deeper lol. Shipping a fix shortly! You can view/fork the running version of your code here: https://stackblitz.com/edit/issue-6?file=index.js

@EricSimons EricSimons changed the title Full activity log [BUGFIX] When app is in failed import state, emitted bundles need to include/respect errors Aug 4, 2017
@EricSimons EricSimons self-assigned this Aug 4, 2017
@EricSimons EricSimons added the bug label Aug 4, 2017
@dwaq
Copy link
Author

dwaq commented Aug 7, 2017

Great, your code from https://stackblitz.com/edit/issue-6?file=index.js appears to be working for me

@EricSimons
Copy link
Member

This bug is now fixed in prod!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants