Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saving changes (leading to forked stackblitz) breaks static asset image serving #493

Closed
thescientist13 opened this issue Dec 16, 2021 · 1 comment
Labels

Comments

@thescientist13
Copy link

thescientist13 commented Dec 16, 2021

Describe the bug

Noticed that if I made changes to a blitz, thus causing a fork, and then re-ran the same npm start command, that the image in the header was not loading anymore.

Link to the blitz that caused the error

https://stackblitz.com/github/ProjectEvergreen/greenwood-getting-started

Steps to reproduce

  1. Load the blitz
  2. Run npm start. Observe the dev server starts and you can see the Greenwood logo in the header
    Screen Shot 2021-12-15 at 9 15 09 PM
  3. Make and save any change to a file (like editing the name field in package.json)
    Screen Shot 2021-12-15 at 9 15 39 PM
  4. This will cause a fork
  5. Run the npm start command again, now the image in the header is not loading
    Screen Shot 2021-12-15 at 9 16 11 PM

Expected behavior

It would be great if the image continued to load. 😃

Screenshots

Provided in the Steps to reproduce section 👆

Platform

  • OS: macOS
  • Browser: Chrome
  • Version: 96

Additional context

The image is referenced in a folder called /assets and is served by a simple Koa server from src/components/header/header.js.

Not sure if this is related to #208 ?

I can make as many changes as I want and keep running npm start and everything is fine, but as soon as I save and get into a fork, the image loading breaks.


Thanks in advance for any help / guidance!

@kc0tlh
Copy link
Collaborator

kc0tlh commented Apr 22, 2022

@thescientist13 thanks for submitting this report! As you determined, this is the same underlying issue as #677 so I will close this report, and we can follow #677 for updates. Cheers!

@kc0tlh kc0tlh closed this as completed Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants