Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching a Hashtag fails with a 404 #133

Closed
cointastical opened this issue Apr 2, 2022 · 3 comments
Closed

Searching a Hashtag fails with a 404 #133

cointastical opened this issue Apr 2, 2022 · 3 comments

Comments

@cointastical
Copy link

The following will result in a 404 - Page not found error message, with the "Alice in wonderland maze" image.
https://stacker.news/search?q=#bitcoin

I would think words for that string without the "#" hashtag prefix would be included in the search results, but probably exact matches including that "#" prefix should get ranked higher in the search results.

There are some instances, such as Episode #123, where the matches without the "#" prefix are probably nearly as close (e.g., "Episode 123". There are probably other quirks with hashtags, I can imagine.

@cointastical
Copy link
Author

I see there was discussion about using hashtags to identify a sub as well, so wanted to share that here as well;
https://stacker.news/items/7767

@huumn huumn added the simple label Apr 12, 2022
@nickkrauts
Copy link

One possible solution: when a user searches using a hashtag, for example "#Bitcoin", we can convert to URL encoded parameters and send "%23Bitcoin" to the browser instead. This would at least squash the bug. I'm thumbing through the code now to see where one could enter this functionality - perhaps in search.js

@huumn
Copy link
Member

huumn commented May 18, 2022

@nickkrauts that's what I did and it was in fact in components/search.js

Fixed locally.

@huumn huumn closed this as completed May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants