Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linking multiple lightning logins #164

Open
huumn opened this issue Jun 13, 2022 · 4 comments
Open

linking multiple lightning logins #164

huumn opened this issue Jun 13, 2022 · 4 comments
Labels
difficulty:medium-hard feature new product features that weren't there before

Comments

@huumn
Copy link
Member

huumn commented Jun 13, 2022

Users are asking. Need to migrate the db from has-a to has-many and provide UI for it.

@ekzyis
Copy link
Member

ekzyis commented May 16, 2023

Another post related to this: https://stacker.news/items/179236

Regarding security:
I think this should be handled the same way as password changes are handled in other services since functionality like this can lead to account takeovers. So this would mean that even logged-in users have to confirm that they still have access to the old wallet to be able to add a new wallet.

If old lightning logins can also be deleted (which I think would be good UX), this would be even more of a concern.

edit: This gets more complicated if a user already has multiple linked wallets 🤔

@ekzyis ekzyis added the feature new product features that weren't there before label May 19, 2023
@rleed
Copy link
Contributor

rleed commented Sep 27, 2023

Is this perhaps a general case of needing to be able to merge SN profiles? I noticed by logging into SN with different methods (GH vs. email e.g.) I get different profiles, and sometimes I would like to merge them.

@huumn
Copy link
Member Author

huumn commented Sep 27, 2023

That's a separate issue. This is for having multiple lightning logins on a single account.

@huumn
Copy link
Member Author

huumn commented Feb 5, 2024

Implementation requirements:

  • lightning pubkey needs to be broken out into its own table and User has-many of them
  • each lightning login need to be given an optional label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty:medium-hard feature new product features that weren't there before
Projects
None yet
Development

No branches or pull requests

3 participants