-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'delete' next to 'edit' while comment is new #195
Comments
I would be happy to work on this. I think I already have a general idea how this could work. Just need to see how 'edit' is implemented. |
Noticed another use case: I accidentally replied to my own comment instead of using the still available edit button here: https://stacker.news/items/70923 |
Delete is a bit tricky. For instance, should you be able to delete a post/comment that someone has tipped you on? Perhaps if you refund them? How about if someone has commented on it? |
Ah, I see. But doesn't the same apply to "edits"? You could edit a comment and just completely change your opinion. Then it also wouldn't make sense to keep the tips or if someone replied to you, would it? But yeah, good point. I didn't think about this before. Refunding seems to make sense. This should be a edge case anyway that someone already tips you while you can still edit/delete a comment. Or at least not the majority of times. However, if someone replied to you, I think deleting a post is a bit more "critical". I could see the possibility of people deleting their comments (while they are still able to) if someone else "successfully" called them out on something / invalidated their opinion and they want to save face by deleting the comment. This seems - at least to me - a bit more "unethical" than simply editing a comment after someone replied to you. Maybe it should always be possible for a reply to point to the actual comment it replied to? However, I imagine this would be vastly more difficult to implement and storage would double for every reply (as far as I can see now). |
I definitely think we eventually want deletes. Just need to figure out all the corners. |
Another idea would be to mark comments as "unconfirmed" until they are no longer able to be deleted. Then users who reply know that the comment may get deleted and they will be refunded if the comment gets deleted (potential tip + 1 sat cost for the reply). This could be visualized by making the comment more transparent or just exposing the timer to all users for example. This is inspired by unconfirmed transactions in bitcoin. Deletion should probably also cost some amount of sats. Further, this idea would mean that the top comment could delete a whole chain of replies. But the whole chain is marked as "unconfirmed" since every reply itself has a timer which will be by definition larger than the timer of the comment they replied to. So this should be obvious that the chain can get deleted. Another idea is to just update a comment with the content |
I think this can be closed since there are now deletes |
YEP! |
Currently, if a user replies to the wrong comment, he is not able to delete the comment afterwards in any way.
I think adding a 'delete' button next to the 'edit' with its countdown after which 'edit' is removed would solve this problem. The countdown should also apply to the 'delete' button.
The text was updated successfully, but these errors were encountered: