Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'delete' next to 'edit' while comment is new #195

Closed
ekzyis opened this issue Sep 15, 2022 · 8 comments
Closed

Add 'delete' next to 'edit' while comment is new #195

ekzyis opened this issue Sep 15, 2022 · 8 comments

Comments

@ekzyis
Copy link
Member

ekzyis commented Sep 15, 2022

Currently, if a user replies to the wrong comment, he is not able to delete the comment afterwards in any way.

I think adding a 'delete' button next to the 'edit' with its countdown after which 'edit' is removed would solve this problem. The countdown should also apply to the 'delete' button.

@ekzyis
Copy link
Member Author

ekzyis commented Sep 15, 2022

I would be happy to work on this. I think I already have a general idea how this could work. Just need to see how 'edit' is implemented.

@ekzyis
Copy link
Member Author

ekzyis commented Sep 18, 2022

Noticed another use case: I accidentally replied to my own comment instead of using the still available edit button here: https://stacker.news/items/70923

@huumn
Copy link
Member

huumn commented Sep 19, 2022

Delete is a bit tricky. For instance, should you be able to delete a post/comment that someone has tipped you on? Perhaps if you refund them? How about if someone has commented on it?

@ekzyis
Copy link
Member Author

ekzyis commented Sep 20, 2022

Ah, I see.

But doesn't the same apply to "edits"? You could edit a comment and just completely change your opinion. Then it also wouldn't make sense to keep the tips or if someone replied to you, would it?

But yeah, good point. I didn't think about this before.

Refunding seems to make sense. This should be a edge case anyway that someone already tips you while you can still edit/delete a comment. Or at least not the majority of times.

However, if someone replied to you, I think deleting a post is a bit more "critical". I could see the possibility of people deleting their comments (while they are still able to) if someone else "successfully" called them out on something / invalidated their opinion and they want to save face by deleting the comment.

This seems - at least to me - a bit more "unethical" than simply editing a comment after someone replied to you.

Maybe it should always be possible for a reply to point to the actual comment it replied to? However, I imagine this would be vastly more difficult to implement and storage would double for every reply (as far as I can see now).

@huumn
Copy link
Member

huumn commented Sep 20, 2022

I definitely think we eventually want deletes. Just need to figure out all the corners.

@ekzyis
Copy link
Member Author

ekzyis commented Oct 16, 2022

Another idea would be to mark comments as "unconfirmed" until they are no longer able to be deleted. Then users who reply know that the comment may get deleted and they will be refunded if the comment gets deleted (potential tip + 1 sat cost for the reply). This could be visualized by making the comment more transparent or just exposing the timer to all users for example.

This is inspired by unconfirmed transactions in bitcoin.

Deletion should probably also cost some amount of sats.

Further, this idea would mean that the top comment could delete a whole chain of replies. But the whole chain is marked as "unconfirmed" since every reply itself has a timer which will be by definition larger than the timer of the comment they replied to. So this should be obvious that the chain can get deleted.

Another idea is to just update a comment with the content [deleted] as I did here when pressing on delete. This would probably be the simplest solution since it's essentially just a reconfigured edit button.

@ekzyis
Copy link
Member Author

ekzyis commented Jan 27, 2023

I think this can be closed since there are now deletes

@huumn
Copy link
Member

huumn commented Jan 27, 2023

YEP!

@huumn huumn closed this as completed Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants