Provide option to clear withdrawal invoices

[huumn]

https://stacker.news/items/75823

[huumn]

I think the ultimate solution is

1. an option to automatically delete withdrawal invoices after X amount of days
2. an option to delete each invoice on a case by case basis

We can keep the amount, etc, but should delete the bolt11 so the receiver's privacy is maintained

[rleed]

I'd like to implement this in the following suggested way, subject to y'alls input:

• add a checkbox option to the user settings to "auto forget withdrawal invoices after 30 days" (pic A)
• add a daily job in the worker thread to perform the selected deletions
• on the invoice detail page for withdrawal invoices, add a link to forget the invoice (pic B)
• when manually deleting the invoice, pop up a warning similar to existing warnings (pic C)
• restrict manual deletion to invoices over 30 days old (per original discussion)

A:

Is 30 days the right optimum? (I pulled it from the original discussion, after already making the image with 7 days.) Alternatively, we could put a drop-down option list with several options. But I guess it isn't necessary...

The info box could say:

• use this to protect receiver privacy
• withdrawal invoices are kept at least 30 days:
  • for debugging purposes
  • to prevent a thief from covering his tracks

B:

First I thought about putting a trash button directly on the wallet history page, but maybe it is better to have this link here? What do you think?

Before the 30 day cutoff, we could substitute a message "these invoice details will be auto-forgotten in X days" or "these invoice details can be manually forgotten in X days"

C:

This is an existing warning...the wording could be adapted slightly if desired, but I guess it fits already.

[huumn]

I think everything in your approach is good.

7 days seems like the right length of time too