-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Our gif proxying sucks #444
Comments
Is it just because of the file size? I agree some kind of loading indicator would be ideal |
It's the nature of gifs. It's like processing 100 images at once. It seems like bumping the CPU/memory of the proxy helped some but it'd be nice to handle failure cases more gracefully |
This means they have enabled automatically to load external images, right? We could maybe just load both requests in parallel or just drop the image proxy all together for users who would load external images anyway ("click to load external images" disabled in settings). On another note, the current "click to load image" is also not good UX. It gives stackers no information why they have to click at all and if they know it's because of external images, we give them no information for an informed decision if they want to load that external image or not. We could at least show the external domain. edit:
that would make the imgproxy obsolete |
GIFs are also cut off. Only first 10 frames are shown here: https://stacker.news/items/249778 |
I think we could improve performance by using lazy loading (so the image proxy does not get hit with 60+ unnecessary requests at the same time whenever someone loads Meme Monday) and using responsive images with -- https://imagekit.io/website-analyzer?taskId=1694474566205&device=desktop edit:
this shouldn't be the case since the image requests should get cached by our CDN |
The majority of gifs people share timeout while being processed by the proxy. The UX is abysmal:
I've given our containers more memory and cpu in the hopes that that improves things but it'd be nice to have something that works reliabely.
The text was updated successfully, but these errors were encountered: