Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Potato" image quality via proxy #451

Closed
huumn opened this issue Aug 28, 2023 · 4 comments · Fixed by #513
Closed

"Potato" image quality via proxy #451

huumn opened this issue Aug 28, 2023 · 4 comments · Fixed by #513
Assignees
Labels

Comments

@huumn
Copy link
Member

huumn commented Aug 28, 2023

Context: https://stacker.news/items/237871

Images of text generally get messed up. We probably need to tune the quality params of the proxy.

@huumn huumn added the bug label Aug 28, 2023
@ekzyis
Copy link
Member

ekzyis commented Sep 8, 2023

We can tune quality params or/and we can provide the option to view the original image.

For example, I had the idea here to make long press show images in full screen (or at least in a very big modal with the background blurred).

There could then be a link there to the original image.

@huumn
Copy link
Member Author

huumn commented Sep 8, 2023

I think we should tune the parameters. By default we shouldn't make text illegible.

I also like the idea of using srcset if we want to vary the quality depending on the context https://developer.mozilla.org/en-US/docs/Learn/HTML/Multimedia_and_embedding/Responsive_images

@ekzyis
Copy link
Member

ekzyis commented Sep 10, 2023

We could use this image to test image quality: https://files.ekzyis.com/public/sn/image_proxy_test.png

@ekzyis ekzyis pinned this issue Sep 20, 2023
@ekzyis ekzyis self-assigned this Sep 20, 2023
@ekzyis
Copy link
Member

ekzyis commented Sep 20, 2023

Site for sample images in different sizes: https://www.learningcontainer.com/sample-jpeg-file-download-for-testing/

@ekzyis ekzyis mentioned this issue Sep 21, 2023
12 tasks
@huumn huumn closed this as completed in #513 Oct 1, 2023
@ekzyis ekzyis unpinned this issue Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants