Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-rotate setting not respected in PWA on Chrome #482

Closed
ekzyis opened this issue Sep 8, 2023 · 7 comments · Fixed by #483
Closed

Auto-rotate setting not respected in PWA on Chrome #482

ekzyis opened this issue Sep 8, 2023 · 7 comments · Fixed by #483
Assignees
Labels

Comments

@ekzyis
Copy link
Member

ekzyis commented Sep 8, 2023

Description

Even if I disable "auto-rotate", the SN PWA still rotates if I rotate my phone.

This is super annoying when lying in bed and similar.

The only other PWA that I have is Mutiny and this doesn't happen there.

Steps to Reproduce

  1. Disable auto-rotate
  2. Rotate phone
  3. SN PWA rotates

Expected behavior

SN PWA does not rotate if auto-rotation is disabled

Screenshots

signal-2023-09-08-145443_002
signal-2023-09-08-145443_003

Environment:

Chrome on Android

Additional context:

I believe this is the case since the latest manifest changes because of orientation: 'any'.

This doesn't happen if I open SN in the browser.

This might be a bug in the PWA implementation of Chrome, not sure. Read here for the specs of orientation

@ekzyis ekzyis added the bug label Sep 8, 2023
@ekzyis ekzyis self-assigned this Sep 8, 2023
@ekzyis
Copy link
Member Author

ekzyis commented Sep 8, 2023

This might be a bug in the PWA implementation of Chrome, not sure. Read here for the specs of orientation

@SatsAllDay @huumn Does this happen for you on iOS with Safari, too?

@SatsAllDay
Copy link
Contributor

If I lock the orientation on my iOS device, the SN PWA does not rotate if I rotate my phone. Does that answer it?

@ekzyis ekzyis changed the title Auto-rotate setting not respected in PWA Auto-rotate setting not respected in PWA on Chrome Sep 8, 2023
@ekzyis
Copy link
Member Author

ekzyis commented Sep 8, 2023

Yes, thanks!

Just tested with Firefox. Setting is respected there.

Tried Brave Browser, setting is not respected there. This makes sense since it's based on Chromium.

Guess I have to use Firefox for the PWA to fix this. This looks like a bug in the Chromium PWA implementation to me.

I am surprised no other stacker has mentioned this yet.

@ekzyis
Copy link
Member Author

ekzyis commented Sep 8, 2023

But Firefox does not support theme color ...

signal-2023-09-08-155948

Why, just why

The web is a mess, lol

@SatsAllDay
Copy link
Contributor

SatsAllDay commented Sep 8, 2023

The web is a mess, lol

Welcome to the front lines :P

@ekzyis
Copy link
Member Author

ekzyis commented Sep 8, 2023

lol, I think that the PWA from Chrome does not respect my auto-rotate settings is not a bug. It's probably just that only Chrome supports orientation: https://developer.mozilla.org/en-US/docs/Web/Manifest/orientation#browser_compatibility

Maybe any is not the correct setting we should use?

@ekzyis
Copy link
Member Author

ekzyis commented Sep 8, 2023

I would propose to just remove orientation all together since it's only supported by Chrome and it's experimental.

If you want to rotate, you can still manually rotate or enable the OS setting.

signal-2023-09-08-161252
press icon in red circle to manually follow phone orientation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants