Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit visible portion of post/comment body and 'click to view more' #549

Closed
huumn opened this issue Oct 6, 2023 · 2 comments
Closed

Limit visible portion of post/comment body and 'click to view more' #549

huumn opened this issue Oct 6, 2023 · 2 comments
Labels
difficulty:good-first-issue feature new product features that weren't there before

Comments

@huumn
Copy link
Member

huumn commented Oct 6, 2023

On even a very large screen, https://stacker.news/items/275618 is 5+ view heights. On mobile, I suspect it's 2x that.

If you are trying to navigate to the comments, it's pretty crappy to scroll so much.

We should visually truncate the text to ~2vh for posts and maybe ~1vh for comments then provide a 'click to view full'.

Ideally this is done using CSS so there isn't vertical layout shift.
@huumn
Copy link
Member Author

huumn commented Oct 7, 2023

Even with the checkbox hack this is probably done with js.

We'll just to reserve enough vertical space to be able to remove the 'read more' without causing layout shift when the page simply loads.

@ekzyis
Copy link
Member

ekzyis commented Oct 20, 2023 •
edited

This would be a nice feature for the comments from unpaywall which are still quite large on mobile.

@huumn huumn added feature new product features that weren't there before difficulty:good-first-issue labels Oct 23, 2023
@huumn huumn closed this as completed Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty:good-first-issue feature new product features that weren't there before
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ekzyis @huumn