Push notification shows wrong deposit amount

[ekzyis]

Description

Multiple push messages are sent on deposits. They then get merged to show a wrong amount. See attached video.

Steps to Reproduce

Deposit funds

Expected behavior

Push notifications shows correct amount

Video

2024-01-19.04-54-47.mp4

Additional context

Probably related to #726

[ekzyis]

What I found out yesterday: It's related to reconnecting but I verified that the finally branch does execute. I thought it might not because we rethrow the error in catch but it does.

But seems like old subscriptions still continue to fire on reconnection.

[ekzyis]

Mhh, can't reproduce locally anymore

[huumn]

Wasn't this caused by what you fixed in #764?

[ekzyis]

Wasn't this caused by what you fixed in #764?

No, #764 was only concerned with worker behavior on reconnects: it confirmed already paid invoices again.

This is about multiple push messages being sent per deposit. You can test in prod by depositing X sats. You should receive a deposit push notification that says you deposited 4*X sats.

Since only deposit push notifications seem to be broken, I think this is related to #726. But afaict, we correctly unsubscribe on errors¹. And as mentioned, wasn't able to reproduce locally anymore.

Maybe we just need to restart the worker? When you deployed 70aa7dd, did you also restart the worker?

Or do you only restart it when there are changes to it? (I would guess the latter)

Footnotes

1. and if reconnecting really does not work automatically, then this shouldn't even be possible ↩

[huumn]

Everything rebuilds and restarts on every deployment.

[ekzyis]

Everything rebuilds and restarts on every deployment.

Mhh, I still get "4 sats deposited" when someone sends me 1 sat.