Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

SOAP fixes #6

Closed
wants to merge 6 commits into from
Closed

SOAP fixes #6

wants to merge 6 commits into from

Conversation

slafs
Copy link
Contributor

@slafs slafs commented Nov 20, 2014

Hello

I know you'll reject this in favor of using openstack-gerrit
but I found several minor bugs in the SOAP protocol that I tried to fix in this PR.

I'll just leave this here :)

because it is used here in this form
if the processed element is a comment - skip it
don't know if the WSDL was valid or invalid but SOAP UI didn't handle this
properly without this fix (there was no operations available).
@openstack-gerrit
Copy link

Thank you for contributing to stackforge/wsme!

stackforge/wsme uses Gerrit for code review.

Please visit http://wiki.openstack.org/GerritWorkflow and follow the
instructions there to upload your change to Gerrit.

@cdevienne
Copy link
Contributor

Hi @slafs

I would like to merge your changes. The really simple way is for you to push them on gerrit, so they can go through the standard reviewing process.

Any other option would remove you as the author of the cset (you would still have credit in the commit message though), which I want to avoid.

Thanks,

Christophe

@slafs
Copy link
Contributor Author

slafs commented Jan 3, 2015

Hi @cdevienne

Would love this. But can you elaborate a bit on this:

The really simple way is for you to push them on gerrit

The gerrit link in README doesn't seem to work (https://review.openstack.org/#/q/project:stackforge/wsme,n,z/) so I'm little confused about what I really should do.

@cdevienne
Copy link
Contributor

The 'simple way' is actually simple for me, and make sure the csets are pushed as they are in the repo.

The thing is that gerrit will not allow me to propose your csets for review. So either I change them to be the author, either you submit them yourself.

To submit them, you have to register on https://review.openstack.org/ (The sign in link), set-up you ssh key, then install git-review (https://wiki.openstack.org/wiki/Gerrit_Workflow#Git_Review_Installation), and use it to push your changes to gerrit ("git review" instead of "git push", see
https://wiki.openstack.org/wiki/Gerrit_Workflow#Project_Setup).

If you have questions don't hesitate. You can ask on irc on #wsme (freenode).

@slafs
Copy link
Contributor Author

slafs commented Jan 5, 2015

Done... I think. https://review.openstack.org/144956

It was hard to find the link for the project though ;)

@cdevienne
Copy link
Contributor

The patch was reviewed and merged.

Thanks a lot !

@slafs
Copy link
Contributor Author

slafs commented Jan 5, 2015

Great! Any plans for a new release?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants