Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

echo "${{ secrets[format()] }}" breaks when cloud platform passwords contain certain special characters #305

Open
mkarpiarz opened this issue Aug 30, 2023 · 1 comment

Comments

@mkarpiarz
Copy link

After this change was introduced: 80b8d71#diff-e02b2a73e84a6045b2f324d6996a8999c22db93e08100eaf26fe7981e065aeadR21, cloud platform passwords with special characters can break the pipeline.

For example with a password containing a bracket, the pipeline will fail with the following error:

Run mkdir -p ~/.config/openstack/
/home/runner/work/_temp/c9f4e5e1-53d8-4e87-b432-14f4100ea505.sh: line 7: syntax error near unexpected token `('
Error: Process completed with exit code 2.

There is probably not much we can do to address this, aside from adding a note advising to not to use special characters in passwords.

@sjpb
Copy link
Collaborator

sjpb commented Sep 5, 2023

Ouch. Thanks for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants