Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sBTC] Feat: Peg-in operation wire format #3486

Merged
merged 20 commits into from
Feb 16, 2023
Merged

Conversation

netrome
Copy link
Contributor

@netrome netrome commented Jan 12, 2023

This PR introduces an alpha version of the wire format for the Peg-in operation, intended for early end-to-end testing of sBTC. This version do not validate the peg wallet address, which is left to an external stacker application for the alpha test phase.

I've created #3494 as a follow-up task to add the validation of the peg wallet address once Epoch 3.0 and the updated .pox contract is ready.

@netrome netrome added this to In progress in stacks-network - sBTC Project via automation Jan 12, 2023
@netrome netrome self-assigned this Jan 12, 2023
@netrome netrome linked an issue Jan 12, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #3486 (9d8675d) into next (1e32f7e) will increase coverage by 0.85%.
The diff coverage is 38.49%.

@@            Coverage Diff             @@
##             next    #3486      +/-   ##
==========================================
+ Coverage   30.55%   31.40%   +0.85%     
==========================================
  Files         304      305       +1     
  Lines      271424   276271    +4847     
==========================================
+ Hits        82923    86760    +3837     
- Misses     188501   189511    +1010     
Impacted Files Coverage Δ
...larity/src/vm/analysis/arithmetic_checker/tests.rs 0.00% <0.00%> (ø)
.../vm/analysis/type_checker/v2_05/tests/contracts.rs 0.00% <0.00%> (ø)
...c/vm/analysis/type_checker/v2_1/tests/contracts.rs 0.00% <0.00%> (ø)
clarity/src/vm/ast/errors.rs 27.74% <0.00%> (-0.19%) ⬇️
clarity/src/vm/database/clarity_store.rs 61.81% <ø> (ø)
clarity/src/vm/docs/mod.rs 0.00% <ø> (ø)
clarity/src/vm/types/serialization.rs 42.05% <ø> (+0.10%) ⬆️
src/burnchains/bitcoin/bits.rs 8.90% <0.00%> (ø)
src/burnchains/tests/affirmation.rs 0.00% <0.00%> (ø)
src/burnchains/tests/burnchain.rs 0.00% <0.00%> (ø)
... and 158 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@netrome netrome mentioned this pull request Jan 12, 2023
7 tasks
@jcnelson jcnelson added the sbtc label Jan 13, 2023
@netrome netrome force-pushed the 3481-sbtc-peg-in-wire-formats branch 4 times, most recently from 63e450b to 51d6627 Compare January 17, 2023 10:07
@netrome netrome changed the title Draft: feat: Peg-in operation wire format Feat: Peg-in operation wire format Jan 17, 2023
@netrome netrome marked this pull request as ready for review January 17, 2023 11:56
@igorsyl igorsyl moved this from In progress to Review in progress in stacks-network - sBTC Project Jan 17, 2023
@igorsyl
Copy link
Contributor

igorsyl commented Jan 17, 2023

Adding @donpdonp, @sergey-shandar and @xoloki as reviewers to become familiar with this code.

@netrome
Copy link
Contributor Author

netrome commented Jan 24, 2023

@jcnelson FYI I'm not authorized to merge this PR. Can you add me as maintainer so I can merge once it's approved and CI is green?

@netrome netrome force-pushed the 3481-sbtc-peg-in-wire-formats branch from 2edf633 to 2d49d87 Compare February 10, 2023 11:51
@netrome
Copy link
Contributor Author

netrome commented Feb 10, 2023

In stx_transfer_btc_integration_test:

 #5 159.5 thread 'tests::neon_integrations::stx_transfer_btc_integration_test' panicked at 'unexpected btc transaction type', testnet/stacks-node/src/tests/neon_integrations.rs:1709:21

This is unrelated to the peg-in changes, and was introduced when develop was merged (which I've reverted now). This test failure needs to be addressed to unblock #3564. FYI @pavitthrap

@netrome netrome force-pushed the 3481-sbtc-peg-in-wire-formats branch from 2d49d87 to 2c742e0 Compare February 15, 2023 09:18
@netrome
Copy link
Contributor Author

netrome commented Feb 15, 2023

Rebased on latest next and CI is green ✔️. @jcnelson I'd love it if you could have a look if this is okay to merge.

Copy link
Member

@jcnelson jcnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great job on this @netrome!

stacks-network - sBTC Project automation moved this from Review in progress to Reviewer approved Feb 16, 2023
@netrome
Copy link
Contributor Author

netrome commented Feb 16, 2023

LGTM! Great job on this @netrome!

Thank you! I'm not currently authorized to merge, can you press the magic button for me @jcnelson?

@igorsyl igorsyl merged commit fd770ec into next Feb 16, 2023
stacks-network - sBTC Project automation moved this from Reviewer approved to Done Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[sBTC] Peg-in wire format
4 participants