-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sBTC] Feat: Peg-in operation wire format #3486
Conversation
Codecov Report
@@ Coverage Diff @@
## next #3486 +/- ##
==========================================
+ Coverage 30.55% 31.40% +0.85%
==========================================
Files 304 305 +1
Lines 271424 276271 +4847
==========================================
+ Hits 82923 86760 +3837
- Misses 188501 189511 +1010
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
63e450b
to
51d6627
Compare
Adding @donpdonp, @sergey-shandar and @xoloki as reviewers to become familiar with this code. |
e31cbf4
to
fbc09eb
Compare
775576f
to
945b8e7
Compare
@jcnelson FYI I'm not authorized to merge this PR. Can you add me as maintainer so I can merge once it's approved and CI is green? |
2edf633
to
2d49d87
Compare
This is unrelated to the peg-in changes, and was introduced when |
2d49d87
to
2c742e0
Compare
Rebased on latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great job on this @netrome!
This PR introduces an alpha version of the wire format for the Peg-in operation, intended for early end-to-end testing of sBTC. This version do not validate the peg wallet address, which is left to an external stacker application for the alpha test phase.
I've created #3494 as a follow-up task to add the validation of the peg wallet address once Epoch 3.0 and the updated
.pox
contract is ready.