Ignore: [sBTC] Feat: Peg out request & fulfillment wire formats #3510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3481-sbtc-peg-in-wire-formats #3510 +/- ##
==================================================================
+ Coverage 31.40% 58.31% +26.91%
==================================================================
Files 305 1 -304
Lines 276271 571 -275700
==================================================================
- Hits 86760 333 -86427
+ Misses 189511 238 -189273 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
netrome
force-pushed
the
3493-sbtc-peg-out-wire-format
branch
from
14cf605
to
acfdecd
Compare
netrome
requested review from
jcnelson,
donpdonp,
igorsyl,
kantai,
sergey-shandar and
xoloki
netrome
changed the title
netrome
force-pushed
the
3481-sbtc-peg-in-wire-formats
branch
from
775576f
to
945b8e7
Compare
netrome
force-pushed
the
3493-sbtc-peg-out-wire-format
branch
from
db54ddd
to
3710e82
Compare
jcnelson
reviewed
Jan 20, 2023
jcnelson
reviewed
Jan 20, 2023
jcnelson
reviewed
Jan 20, 2023
jcnelson
reviewed
Jan 20, 2023
netrome
moved this from In progress
to Review in progress
in stacks-network - sBTC Project
sergey-shandar
approved these changes
Jan 24, 2023
stacks-network - sBTC Project
automation
moved this from Review in progress
to Reviewer approved
Jan 24, 2023
jcnelson
reviewed
Jan 24, 2023
jcnelson
reviewed
Jan 24, 2023
jcnelson
reviewed
Jan 24, 2023
jcnelson
reviewed
Jan 24, 2023
jcnelson
reviewed
Jan 24, 2023
jcnelson
reviewed
Jan 24, 2023
Co-authored-by: Jude Nelson <judecn@gmail.com>
netrome
force-pushed
the
3493-sbtc-peg-out-wire-format
branch
2 times, most recently
from
d923e63
to
2ef8209
Compare
Awesome! I've updated & rebased the PR now. I will merge this one once CI passes, it looks like I'm authorized to do so now. Thank you for all the help! 🙏 Edit: I forgot to update the branch. I'm not authorized to merge into |
…eg ops Co-authored-by: Jude Nelson <judecn@gmail.com>
netrome
force-pushed
the
3493-sbtc-peg-out-wire-format
branch
from
2ef8209
to
1f4594b
Compare
|
Oh, forgot to point to next... I'll open a new PR to fix it. Edit: Please refer to #3577 for the final merge. |
netrome
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing wire formats for the peg out request and peg out fulfillment sBTC operations. This PR do not include any signature or sBTC validation for the peg out request. I have created #3514 for this.
I will point this PR to
nextonce #3481 is merged.