Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clarity] All check errors must be handled as runtime errors #3107

Closed
jcnelson opened this issue Apr 19, 2022 · 4 comments
Closed

[clarity] All check errors must be handled as runtime errors #3107

jcnelson opened this issue Apr 19, 2022 · 4 comments

Comments

@jcnelson
Copy link
Member

Right now, (at-block) can emit CheckErrors which cause the transaction to be invalid, as well as the block that includes it. In Stacks 2.1, we should make it so that any error emitted by (at-block) is a RuntimeError, so at least the transaction will be mineable and fees will be collected.

@jcnelson jcnelson self-assigned this Apr 19, 2022
@jcnelson jcnelson added this to To do in Stacks 2.1 via automation Apr 19, 2022
@jcnelson jcnelson changed the title [clarity] (at-block) errors must all be runtime errors [clarity] All check errors must be handled as runtime errors Jul 25, 2022
@jcnelson
Copy link
Member Author

N.B. this applies to all check errors. We should not merely re-cast all check errors as runtime errors, but instead treat check errors the way we do for runtime errors -- i.e. they don't invalidate the block; they only debit the sender the tx fee (but the tx receipt should contain the original check error).

@jcnelson jcnelson moved this from To do to In progress in Stacks 2.1 Aug 1, 2022
@saralab
Copy link
Contributor

saralab commented Aug 3, 2022

A good one for @obycode to help with.

@obycode
Copy link
Contributor

obycode commented Aug 3, 2022

👍 I just finished reviewing the PR.

@jcnelson jcnelson moved this from In progress to Review in progress in Stacks 2.1 Aug 3, 2022
@jcnelson
Copy link
Member Author

jcnelson commented Aug 3, 2022

I already did this one @saralab.

Thank you for your review @obycode!

@jcnelson jcnelson closed this as completed Aug 5, 2022
Stacks 2.1 automation moved this from Review in progress to Done Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants