Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Optimization] Improve efficiency of checking for contract existence prior to contract deploy #4440

Open
cylewitruk opened this issue Feb 28, 2024 · 0 comments
Open

[Optimization] Improve efficiency of checking for contract existence prior to contract deploy #4440

cylewitruk opened this issue Feb 28, 2024 · 0 comments
Assignees
@cylewitruk
Labels
optimization Update speed, efficiency, or quality of a feature. Size: 🐭 XS (< 1 day)

Comments

@cylewitruk
Copy link
Member

cylewitruk commented Feb 28, 2024 •
edited

The current code in stackslib/src/chainstate/stacks/db/transactions.rs : ~1165 attempts to load the entire contract from the backing store just to check for the contract's existence. This can be optimized to use a method which ultimately uses an EXISTS query instead.

Related to #4428.
@cylewitruk cylewitruk added the enhancement Iterations on existing features or infrastructure. label Feb 28, 2024
@cylewitruk cylewitruk self-assigned this Feb 28, 2024
@cylewitruk cylewitruk mentioned this issue Feb 28, 2024
Draft
6 tasks
@cylewitruk cylewitruk added optimization Update speed, efficiency, or quality of a feature. and removed enhancement Iterations on existing features or infrastructure. labels Feb 28, 2024
@cylewitruk cylewitruk changed the title [Improvement] Improve efficiency of checking for contract existence prior to contract deploy [Optimization] Improve efficiency of checking for contract existence prior to contract deploy Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cylewitruk cylewitruk

Labels
optimization Update speed, efficiency, or quality of a feature. Size: 🐭 XS (< 1 day)
Projects
Stacks Core Eng
Status: Status: 🆕 New
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cylewitruk